Repository navigation
fix(packaging): ship mkconcore's runtime files in the wheel and add a package CI job - #699
Open
yadavchiragg wants to merge 1 commit into
Open
yadavchiragg wants to merge 1 commit into
yadavchiragg wants to merge 1 commit into
Conversation
…el, add a package CI job A regular pip install of the built wheel contained mkconcore.py but not copy_with_port_portname.py or any of the runtime files mkconcore copies into a study (concore.hpp, Dockerfile.*, .m/.v/.java/.jl helpers, mkcompile), so 'concore build' failed with ModuleNotFoundError. Add the missing module, install the runtime files next to mkconcore.py via a build_py step, include them in the sdist via MANIFEST.in, and add a CI job that builds the sdist and wheel, checks them with twine, installs the wheel in a clean venv, verifies every file mkconcore.py references is present, and builds studies with the installed command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pip install .(non-editable) gives a package whereconcore buildcannot work:The wheel only contains mkconcore.py, concore.py, concoredocker.py and concore_base.py. It is missing copy_with_port_portname.py (imported by mkconcore.py) and every runtime file mkconcore.py copies into a study from next to itself: concore.hpp/concore_base.hpp, Dockerfile.*, the .m/.v/.java/.jl helpers, mkcompile, tools/extract_graphml.py. Editable installs (
pip install -e .) are unaffected, which is why it went unnoticed.Change
copy_with_port_portnameto py-modulesbuild_pystep that installs the runtime files next to mkconcore.py (where_resolve_concore_path()looks for them)packagejob (ubuntu-24.04): build sdist + wheel,twine check, install the wheel in a clean venv, check that every file mkconcore.py references (and that exists in the repo) is present in the installed package, then build a Python project (posix + docker) and testsou/testSM1 (C++) with the installedconcorecommandTesting
concore buildfrom there: output matches a build from the repo (apart from study name/timestamp)Not included / questions
concorename may need checking on PyPI)